Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-3157

Improve FuzzySnapshotRelatedTest to avoid flaky due to issues like connection loss

    XMLWordPrintableJSON

Details

    Description

      hanm noticed that the test might failure because of ConnectionLoss when trying to getData, here is an example, we should catch this and retry to avoid flaky.

      Internally, we 'fixed' flaky test by adding junit.RetryRule in ZKTestCase, which is the base class for most of the tests. I'm not sure this is the right way to go or not, since it's actually 'hiding' the flaky tests, but this will help reducing the flaky tests a lot if we're not going to tackle it in the near time, and we can check the testing history to find out which tests are flaky and deal with them separately. So let me know if this seems to provide any benefit in short term, if it is I'll provide a patch to do that.

      Attachments

        Issue Links

          Activity

            People

              andor Andor Molnar
              lvfangmin Fangmin Lv
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h
                  1h