Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-2642

ZooKeeper reconfig API backward compatibility fix

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. It appears this was done to document that these are methods have access restrictions. However, this change breaks Apache Curator (and possibly other clients). Curator APIs will have to be changed and/or special methods need to be added. A breaking change of this kind should only be done when the benefit is overwhelming. In this case, the same information can be conveyed with documentation and possibly a deprecation notice.

      Revert the creation of the ZooKeeperAdmin class and move the reconfig() methods back to the ZooKeeper class with additional documentation.

      Attachments

        1. ZOOKEEPER-2642-3.5.patch
          21 kB
          Jordan Zimmerman
        2. ZOOKEEPER-2642.patch
          21 kB
          Jordan Zimmerman
        3. ZOOKEEPER-2642.patch
          101 kB
          Jordan Zimmerman
        4. ZOOKEEPER-2642.patch
          21 kB
          Jordan Zimmerman
        5. ZOOKEEPER-2642.patch
          21 kB
          Jordan Zimmerman
        6. ZOOKEEPER-2642.patch
          21 kB
          Jordan Zimmerman
        7. ZOOKEEPER-2642.patch
          21 kB
          Jordan Zimmerman

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            randgalt Jordan Zimmerman
            randgalt Jordan Zimmerman
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 0.5h
                0.5h

                Slack

                  Issue deployment