Details
-
Improvement
-
Status: Resolved
-
Minor
-
Resolution: Fixed
-
None
Description
IsPodFitNodeViaPreemption has defined named returns but does not use them. They should be removed as the way they are used can cause issues that are hard to debug.
As part of this change we need to further cleanup:
- The variable ok also gets shadowed multiple times, not just from the named return declaration.
- The if construct around GetPodNoLock() is not needed as it returns a nil for the pod if it returns false. Just adding the result for the pod always has the same effect.
Attachments
Issue Links
- relates to
-
YUNIKORN-2616 Remove unused bool return from PreemptionPredicates()
- Resolved
- links to