Uploaded image for project: 'Yetus'
  1. Yetus
  2. YETUS-1222

smart-apply-patch EXTRA_ARGS should be an array

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 0.14.1
    • 0.15.0
    • Precommit
    • None
    • The undocumented EXTRA_ARGS environment variable is now expected to be an array.
    • Important

    Description

      There is an unprotected EXTRA_ARGS in smart-apply-patch that newer versions of shellcheck (correctly) mark as SC2086. Given that it appears to be undocumented and how passing --gpg-sign will break any external input, let's change it to correctly be an array. It is still not recommended to depend on this variable, however.

      Attachments

        Issue Links

          links to

          Web Link GitHub Pull Request #303

          Activity

            People

              aw Allen Wittenauer
              aw Allen Wittenauer
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m