Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5992

revert the visibility of interface AllocationFileLoaderService.Listener to public for outside usage

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Duplicate
    • 3.0.0-alpha2
    • None
    • scheduler
    • None

    Description

      The visibility of interface AllocationFileLoaderService.Listener is changed from public to default by YARN-4997.
      This may cause some downsteam like Hive with compile error:

      Hive/src/shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/FairSchedulerShim.java:[45,67] 
      org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.AllocationFileLoaderService.Listener is not public in 
      org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.AllocationFileLoaderService; cannot be accessed from outside package
      

      org/apache/hadoop/hive/schshim/FairSchedulerShim.java uses the interface like below:

      allocsLoader.setReloadListener(new AllocationFileLoaderService.Listener() {
            @Override
            public void onReload(AllocationConfiguration allocs) {
              allocConf.set(allocs);
            }
          });
      

      So can we revert the visibility of AllocationFileLoaderService.Listener to public so that the downstream can use the interface as before, otherwise, the downstream should make some changes.

      Attachments

        1. YARN-5992.patch
          1 kB
          Pan Yuxuan

        Issue Links

          Activity

            People

              Unassigned Unassigned
              panyuxuan Pan Yuxuan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: