Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-10580

Fix some issues in TestRMWebServicesCapacitySchedDynamicConfig

    XMLWordPrintableJSON

Details

    • Reviewed

    Description

      YARN-10512 introduced some changes that could be fixed, pbacsko highlighted those issues with this comment.

      Pasting the contents of the comment as a reference

      #1 In TestRMWebServicesCapacitySchedDynamicConfig:

      config.set(YarnConfiguration.SCHEDULER_CONFIGURATION_STORE_CLASS,
      	        YarnConfiguration.MEMORY_CONFIGURATION_STORE);
      

      This call is repeated multiple times, this could be set somewhere else.

       

      #2 In TestRMWebServicesCapacitySchedDynamicConfig:

      validateSchedulerInfo(json, "weight", "root.default", "root.test1", "root.test2");
      

      "root.default", "root.test1" and "root.test2" are the same in all cases, you might want to drop them

       

      #3 In TestRMWebServicesCapacitySchedDynamicConfig

                @Before
      	  @Override
      	  public void setUp() throws Exception {
      	    super.setUp();
      	  }
      

      This method does nothing, can be removed.

      Attachments

        Issue Links

          Activity

            People

              tdomok Tamas Domok
              snemeth Szilard Nemeth
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 50m
                  50m