Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-3927

com.opensymphony.xwork2.interceptor.ParametersInterceptor incorrect message in log

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.3.7
    • 2.3.8
    • Core Interceptors
    • None
    • centos/tomcat

    Description

      Hello,

      Think the notifyDeveloper(..) message should be before the return true; statement!

          protected boolean isExcluded(String paramName) {
              if (!this.excludeParams.isEmpty()) {
                  for (Pattern pattern : excludeParams) {
                      Matcher matcher = pattern.matcher(paramName);
                      if (matcher.matches()) {
                        // messsage here?  
                        return true;
                      }
                  }
              }
              notifyDeveloper("Parameter [#0] is on the excludeParams list of patterns!", paramName);
              return false;
          }
      

      Attachments

        Activity

          People

            lukaszlenart Lukasz Lenart
            ghuber Greg Huber
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: