Uploaded image for project: 'Wink'
  1. Wink
  2. WINK-297

serviceability improvement; externalize strings, confirm formatting

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.1.2
    • 1.1.2
    • Client, Common, Server
    • None
    • Patch Available

    Description

      We've needed serviceability improvements for a while. Here's the first pass. I've externalized all strings that should be externalized, marked the rest with //$NON-NLS-#$ via Eclipse's tool, and here's the cool part: wrote a unittest to do the following:

      1) checks that the strings that should be externalized are externalized (only debug messages do not need to be externalized)
      2) checks that all keys referred to by Messages.getMessage actually exist
      3) checks that there are no unused keys in the resource.properties file
      4) checks that the number of params matches up with the number of braces {} in a formatted log string, both externalized and non-externalized

      See attached patch. The test is under org.apache.wink.common.internal.i18n.MessagesTest.

      I'll wait to commit this until the 1.1.1 release vote and process is done.

      Attachments

        1. WINK-297.patch
          223 kB
          Michael Rheinheimer

        Activity

          People

            rott Michael Rheinheimer
            rott Michael Rheinheimer
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: