Uploaded image for project: 'Maven Wagon'
  1. Maven Wagon
  2. WAGON-570

Use RedirectStrategy from HttpClient rather than a custom approach

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.3.3
    • 3.4.0
    • wagon-http
    • None

    Description

      We have a custom implementation where we follow relocations for status codes 3xx. We can leverage RedirectStrategy implementations instead doing this on our own.

      WAGON-568 revealed a very serious bug in our codebase. We blindly assume that requests can always be retried, regardless whether the HttpEntity is repeatable or not. This can lead to a lockup of the transport because we advertise a content length on input streams, but cannot deliver those bytes. It will block until the server sends a 408.

      Attachments

        Issue Links

          Activity

            People

              michael-o Michael Osipov
              michael-o Michael Osipov
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m