[TS-4779] Remove SET_CLOSE_ON_EXEC #ifdef's from socket code. - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Task
Status: Closed
Priority: Major
Resolution: Implemented
Affects Version/s: None
Fix Version/s: 7.0.0
Component/s: Network
Labels:
None

Description

This appears to be set nowhere, and so effectively disables CLOEXEC. jpeach@apache.org suggests we remove just the #ifdef's and thereby enable CLOEXEC. I agree with this approach, but it is a change in behavior.

$ grep -ir CLOSE_ON_EXEC
iocore/net/UnixConnection.cc:#ifdef SET_CLOSE_ON_EXEC
iocore/net/UnixConnection.cc:#ifdef SET_CLOSE_ON_EXEC
iocore/net/Connection.cc:#ifdef SET_CLOSE_ON_EXEC
iocore/net/Connection.cc:#ifdef SET_CLOSE_ON_EXEC

Attachments

Issue Links

links to

GitHub Pull Request #934

Activity

People

Assignee:: Phil Sorber

Reporter:: Phil Sorber

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 24/Aug/16 01:22

Updated:: 07/Nov/16 23:27

Resolved:: 26/Aug/16 21:40

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 20m