Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-1055

Wrong implementation of TSHttpSsnArgGet

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.1.1
    • 3.1.2, 3.0.3
    • TS API

    Description

      There is a different between the interface of TSHttpSsnArgGet and it implemenation.
      In the interface (proxy/api/ts/ts.h.in):
      tsapi void* TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx);
      In the implementation(proxy/InkAPI.cc):
      void * TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)

      So, I wrote a simple patch to fix this problem:

      Index: InkAPI.cc
      ===================================================================
      — InkAPI.cc (revision 1220421)
      +++ InkAPI.cc (working copy)
      @@ -5500,7 +5500,7 @@
      }

      void *
      -TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)
      +TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx)
      {
      sdk_assert(sdk_sanity_check_http_ssn(ssnp) == TS_SUCCESS);
      sdk_assert(arg_idx >= 0 && arg_idx < HTTP_SSN_TXN_MAX_USER_ARG);

      Attachments

        Activity

          People

            i.galic Igor Galić
            kopely Yakov Kopel
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Remaining Estimate - 24h
                24h
                Logged:
                Time Spent - Not Specified
                Not Specified