Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5772

Add UUID support for C++

    XMLWordPrintableJSON

Details

    • New Feature
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 0.21.0
    • C++ - Compiler
    • None

    Description

      Starting the discussion to add UUID support for C++.

      I have started with an implementation (See PR linked soon)

      Open points for discussion:

      1. Is there perhaps a need to add a wrapper class for UUID?
        1. I started off with std::string for ease-of-use
        2. 'ease-of-use' has the drawback of ease of miss-use...
        3. Something lightweight as a strong wrapper to wrap a `uint8_t data[16];`
          1. A wrapper gives us the ability to add utility functions, like `to_string()` and `from_string()`
          2. Can use boost::uuids::uuid in the implementation, hidden from users (see current implementation)
        4. I will see if I can't implement something while this PR is looked at.
      2. Can someone help with some cross tests
        1. With the absence of working dockers I am really struggling to get other languages compiled.
        2. I don't have enough experience with other languages to effectively do this
        3. I will probably be able to add Java tests if there is something to build on (pointers needed)
      3. How important is the JSON side?
        1. I did add the support but I see only go has some support for it.
      4. (edit) How important is the HOST vs Network order on the UUID?

      Attachments

        Issue Links

          Activity

            People

              cjcombrink Carel
              cjcombrink Carel
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h