Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5726

package upgrades and consolidation/improvement of build targets checks

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.20.0
    • netstd - Library
    • None

    Description

      There are a few packages that have been deprecated in the meantime, so we should strive to remove/replace where possible. Since we still support netstandard2.0 the remains that are still needed to build those are prepared with Condition attributes in the *.csproj files (until the day comes when we finally can get rid of it)

      Additionally, a few #if checks have been found to cause issues in some CI environments, e.g. version specific NETSTANDARD2_0 symbols are only generated for the exact target,, while for all implicit targets only the <framework>_OR_GREATER symbols are defined. The patch consolidates and enhances all of these #if checks to prevent against that.

      Attachments

        Issue Links

          Activity

            People

              jensg Jens Geyer
              jensg Jens Geyer
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m