Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5725

Thrift SSL server stops working if the file descriptor returned is zero

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 0.19.0
    • 0.19.0
    • C++ - Library
    • None

    Description

      When the Thrift OpenSSL server gets a file descriptor of 0 (which is valid), the server stops working and cannot accept new connections because of the following code in TSSLSocket.cpp:

       

      if (BIO_get_fd(bio, &fdSocket) <= 0)
      { throw TSSLException("BIO_get_fd failed"); }
      

       

      The fix would be to just change the comparison from <= to <

      Attachments

        Issue Links

          Activity

            People

              psarkar24 Prasenjit Sarkar
              psarkar24 Prasenjit Sarkar
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m