Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5662 zephyr umbrella
  3. THRIFT-5659

protocol: declare when methods override

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 0.18.0
    • C++ - Library
    • None

    Description

      This avoids compiler warnings about inconsistent use of `override` like the one below.

      In file included from /Users/cfriedt/workspace/thrift/test/cpp/src/TestServer.cpp:29:
      /Users/cfriedt/workspace/thrift/lib/cpp/src/thrift/protocol/TJSONProtocol.h:255:8: warning: 'checkReadBytesAvailable' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
        void checkReadBytesAvailable(TList& list)
             ^
      /Users/cfriedt/workspace/thrift/lib/cpp/src/thrift/protocol/TProtocol.h:563:16: note: overridden virtual function is here
        virtual void checkReadBytesAvailable(TList& list)

      PR is here:
      https://github.com/apache/thrift/pull/2687

      See also:

      https://github.com/zephyrproject-rtos/gsoc-2022-thrift/issues/147

       

      Attachments

        Issue Links

          Activity

            People

              cfriedt Christopher Friedt
              cfriedt Christopher Friedt
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m