Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5576

fix old-style cast at const value ctor/copy and redundant copy at ctor

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.16.0
    • 0.17.0
    • C++ - Compiler

    Description

      The compiler warnings: of old-style cast

      /root/swc-db/src/cc/include/swcdb/thrift/gen-cpp/Service_types.h: In constructor ‘SWC::Thrift::FU_LI::FU_LI()’:
      /root/swc-db/src/cc/include/swcdb/thrift/gen-cpp/Service_types.h:3397:32: warning: use of old-style cast to ‘enum SWC::Thrift::FU_LIST_OP::type’ [-Wold-style-cast]
       3397 |           op((FU_LIST_OP::type)0),
            |                                ^
            |              -
            |              static_cast<     --
            |                               > (0)
      

      The redundant copy at constructor

        FU_LB() noexcept
              : ctrl(0),
                op((FU_LIST_OP::type)0),
                pos(0) {
          op = (FU_LIST_OP::type)0;
      
        }
        virtual ~FU_LB() noexcept;
      

      Attachments

        Issue Links

          Activity

            People

              kashirin.alex Kashirin Alex
              kashirin.alex Kashirin Alex
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h