Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5053

Fix the netstd tutorial console logging and README

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.14.0
    • netstd - Library
    • None

    Description

      In my environment, Client -help doesn't show any help messages before it stops.

      thrift/tutorial/netstd$ Client/bin/Debug/netcoreapp3.1/Client -help
      thrift/tutorial/netstd$ 
      

      To fix this, disposing the ServiceProvider is required. https://github.com/aspnet/Logging/issues/631

      In addition, there are some minor mistakes in README.md. For example:

      • (Server|Client) -h doesn't work.
      • On Linux, the generated executable names are "Client" and "Server" (camel-cased), not "client" and "server"
      • Server's multiplexed protocol is not documented
      • Python examples don't address THRIFT-4002

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            sekikn Kengo Seki
            sekikn Kengo Seki
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m

                Slack

                  Issue deployment