[THRIFT-4969] PHP test doesn't check the code generation with php:classmap - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 0.13.0
Component/s: Test Suite
Labels:
None

Description

In test/php/Makefile.am:

 20 stubs: ../ThriftTest.thrift
 21         $(THRIFT) --gen php ../ThriftTest.thrift
 22         $(THRIFT) --gen php:inlined ../ThriftTest.thrift
 23         $(MKDIR_P) gen-php-classmap
 24         $(THRIFT) -out gen-php-classmap --gen php ../ThriftTest.thrift

The last command generates the same code as the first one's. It should test --gen php:classmap option instead of --gen php.

Attachments

Issue Links

links to

GitHub Pull Request #1889

Activity

People

Assignee:: Kengo Seki

Reporter:: Kengo Seki

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 04/Oct/19 15:13

Updated:: 16/Oct/19 22:26

Resolved:: 08/Oct/19 21:58

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

20m