Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4725

Change Return Type Signature of Process Methods

    XMLWordPrintableJSON

Details

    Description

      The method signature of TProcessor and TAsyncProcessor is:

       

      public boolean process(...) throws TException;
      

      It's not clear what the return value here because there is no documentation, but parts of the code do not even bother checking the return value. All of the returns, save one, are hard-coded to true. If there is a problem, code should throw an Exception. Make this a void method.

      Note: This the method signature in other languages is also a boolean.

      Attachments

        Issue Links

          Activity

            People

              jking3 James E. King III
              belugabehr David Mollitor
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m