Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4620

TZlibTransport.cpp doesn't ensure that there is enough space for the zlib flush marker in the buffer.

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.9
    • 0.12.0
    • C++ - Library

    Description

      I asked this question on stack overflow related to a crash that I have been getting with Thrift.

      The problem occurs when using TZlibTransport.cpp. After writing to the buffer a few times, we do a flush. If there isn't enough space in cwbuf_ , the Thrift flush marker is split across two messages, which causes an error in the client, as a deflate stream can't start with a partial flush marker, ff.

      Thrift should assure that there will be enough space in the buffer for the complete flush marker, before a deflate.

       

      Attachments

        Issue Links

          Activity

            People

              jking3 James E. King III
              ldsrc Dominic Coyne
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: