Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4272

warnings in glibc library

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.14.0
    • C glib - Library
    • None

    Description

      Travis emits a gazillion of warnings during glib-c builds. Amongst some compatibility related things there are some quite interesting ones:

      testtransportsslsocket.c:530:21: warning: initializer-string for char array is
            too long
              guchar match[10] = TEST_DATA;
                                 ^~~~~~~~~
      testtransportsslsocket.c:35:21: note: expanded from macro 'TEST_DATA'
      #define TEST_DATA { "GET / HTTP/1.1\n\n" }
                          ^~~~~~~~~~~~~~~~~~~~
      
      

      and

      src/thrift/c_glib/transport/thrift_ssl_socket.c:147:10: warning: implicit
            declaration of function 'thrift_socket_is_open' is invalid in C99
            [-Wimplicit-function-declaration]
        return thrift_socket_is_open(transport);
               ^
      src/thrift/c_glib/transport/thrift_ssl_socket.c:179:8: warning: implicit
            declaration of function 'thrift_socket_open' is invalid in C99
            [-Wimplicit-function-declaration]
        if (!thrift_socket_open(transport, error)) {
             ^
      src/thrift/c_glib/transport/thrift_ssl_socket.c:185:7: warning: implicit
            declaration of function 'thrift_socket_close' is invalid in C99
            [-Wimplicit-function-declaration]
            thrift_socket_close(transport, &tmperr);
            ^
      

      Attachments

        Issue Links

          Activity

            People

              zeshuai007 Zezeng Wang
              jensg Jens Geyer
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 20m
                  1h 20m