Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2986

Audit Cocoa library to address architecture-ignorant byte-swapping

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Won't Do
    • 0.9.2
    • 0.13.0
    • Cocoa - Library
    • None

    Description

      This happens at least in TFramedTransport, where -flush manually swaps the length. Except, on a big-endian platform, it just swapped it from network byte order.

      For 32-bit values, htonl() will suffice, though the CFSwap… or NSSwap… families might be a better choice depending on the types in play.

      Attachments

        Activity

          People

            jking3 James E. King III
            jeremyw.sherman Jeremy W. Sherman
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 2h
                2h
                Remaining:
                Remaining Estimate - 2h
                2h
                Logged:
                Time Spent - Not Specified
                Not Specified