Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2099

Stop TThreadPoolServer with alive connections.

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • New Feature
    • Status: Closed
    • Major
    • Resolution: Duplicate
    • 0.9
    • 0.9.3
    • C++ - Library
    • None
    • Ubuntu 12.04, Thrift 0.9, Nginx 1.4.1, Python 2.7.3, GCC 4.6.3

    Description

      Now if client of TThreadPoolServer kept alive connection (for example if requests to thrift-server are forwarded from nginx-server, which is set up so that the connections between him and thift-server are kept alive), method TThreadPoolServer::stop does not stopped server. It continues work until client (nginx-server) will not stopped.

      void StopThread(shared_ptr<EchoService> const &echo_service_handler,
      				shared_ptr<TThreadPoolServer> &server,
      				shared_ptr<ThreadManager> &thread_manager)
      {
      	while (echo_service_handler->GetRequestsCount() < 3)
      	{
      		sleep(1);
      	}
      	std::cout << "Stop service." << std::endl;
      	server->stop();
      }
      

      I think that ability to stop thrift-server with alive connections will be useful.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jking3 James E. King III
            lyobzik Aleksey Zanin
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment