Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1846

Restore socket.h header to support builds with Android NDK

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.9
    • 0.9.1
    • C++ - Library
    • None

    • Building with Android Linux NDK R8D (and, it looks like, all previous NDKs)

    • Patch Available

    Description

      Unlike every other rational un.h that I've seen, the sys/un.h (actually linux/un.h) distributed with the Android NDK doesn't define sa_family_t or include another header that does. Removal of socket.h in THRIFT-1740 broke the Android build.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-1865 Thrift don't build on Android

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            People

              nicolastr Nicolas Trésegnie
              nater Nate Rosenblum
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: