Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1025

C++ ServerSocket should inherit from Socket with the necessary Ctor to listen on connections from a specific host (similar to perl library)

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.9.3
    • C++ - Library
    • None
    • any

    Description

      Perl library ServerSocket inherits from Socket the ctor ServerSocket->new( addr, port) which enables to accept the connections from specified host only (for security reasons for instance).

      package Thrift::ServerSocket;
      use Socket qw(IPPROTO_TCP TCP_NODELAY);
      use base qw( Thrift::Socket Thrift::ServerTransport );

      while surprisingly C++ ServerSocket omits inheriting from Socket.
      class TServerSocket : public TServerTransport {

      Regards.
      Valery.

      Attachments

        1. THRIFT-1025.patch
          10 kB
          James E. King III

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jking3 James E. King III
            kreidenko@f5.com Valery Kreidenko
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment