Uploaded image for project: 'Traffic Control'
  1. Traffic Control
  2. TC-502

ORT fails to handle non-file arguments

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.1.0
    • 2.2.0
    • Traffic Ops ORT
    • None

    Description

      ORT currently processes the parameters of all plugins on the remap.config line as though they were files. However, parameters to `cachekey.config` are parsed as parameters directly on the remap line. So, for example, if you have a remap line that contains something like this:

      @plugin=cachekey.so @pparam=--remove-path=true

      That will cause ORT to attempt to load a config file named --remove-path=true. ORT fails to accomplish this in several ways and produces a variety of errors:

      DEBUG Starting processing of config file: --remove-path=true
      WARN --remove-path=true is being processed with an unknown service

      INFO: ======== Start processing config file: --remove-path=true ========
      Use of uninitialized value in concatenation (.) or string at /opt/ort/traffic_ops_ort.pl line 2515.
      Use of uninitialized value $dir in -d at /opt/ort/traffic_ops_ort.pl line 645.
      Use of uninitialized value $dir in concatenation (.) or string at /opt/ort/traffic_ops_ort.pl line 648.
      /bin/mkdir: missing operand
      Try '/bin/mkdir --help' for more information.
      Use of uninitialized value $dir in pattern match (m//) at /opt/ort/traffic_ops_ort.pl line 649.
      Use of uninitialized value $dir in pattern match (m//) at /opt/ort/traffic_ops_ort.pl line 653.
      Use of uninitialized value $dir in concatenation (.) or string at /opt/ort/traffic_ops_ort.pl line 657.
      DEBUG Directory created: .
      Use of uninitialized value $result in pattern match (m//) at /opt/ort/traffic_ops_ort.pl line 2482.
      Use of uninitialized value $size in numeric eq (==) at /opt/ort/traffic_ops_ort.pl line 2488.
      Use of uninitialized value $url in concatenation (.) or string at /opt/ort/traffic_ops_ort.pl line 2489.
      ERROR URL:  returned empty!
      

      ORT should probably skip "files" that start with -.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              alficles Chris Lemmons
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: