Uploaded image for project: 'MINA SSHD'
  1. MINA SSHD
  2. SSHD-839

Possible bug in DefaultForwardingFilter class

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • 2.1.0
    • 2.1.0
    • None

    Description

      Hi, I found a possible bug in method stopLocalPortForwarding() of class DefaultForwardingFilter.

      The effect is that the port bound IS NOT unbound after calling this method.

      For example :

      2018-08-08 15:28:02.054 [CMDSRV-2] DEBUG o.a.s.c.i.n.Nio2Acceptor.bind - Binding Nio2Acceptor to address /127.0.0.1:51080
      2018-08-08 15:28:02.054 [CMDSRV-2] DEBUG o.a.s.c.f.DefaultForwardingFilter.startLocalPortForwarding - startLocalPortForwarding(127.0.0.1:51080 -> 192.168.50.97:46321): 127.0.0.1:51080

       

      2018-08-08 15:28:21.025 [] DEBUG o.a.s.c.f.DefaultForwardingFilter.stopLocalPortForwarding - stopLocalPortForwarding(127.0.0.1:51080) unbind 192.168.50.97:46321

      The port bound is 51080 on localhost(127.0.0.1).

      This port is not unbounded.

      I think that the problem is on this statement :

                      acceptor.unbind(bound.toInetSocketAddress());

      The statement SHOULD BE instead :

                      acceptor.unbind(local.toInetSocketAddress());

       

      Let me know what you think about this issue.

      Thank you in advance

      Roberto

      Attachments

        Activity

          People

            lgoldstein Lyor Goldstein
            roberto.deandrea Roberto Deandrea
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: