Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-31172

RecordBinaryComparator Tests failing on Big Endian Platform (s390x)

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Incomplete
    • 2.4.5
    • None
    • SQL

    • Architecture: Big Endian s390x

      Operating Systems:

      • RHEL 7.x
      • RHEL 8.x
      • Ubuntu 16.04
      • Ubuntu 18.04
      • Ubuntu 19.10
      • SLES 12 SP4 and SLES 12 SP5
      • SLES 15 SP1
    • Patch

    Description

      Failing Test Cases in the RecordBinaryComparatorSuite:

      • testBinaryComparatorWhenSubtractionIsDivisibleByMaxIntValue
      • testBinaryComparatorWhenSubtractionCanOverflowLongValue

      Test cases failed after the change related to:

      Github Pull Request #26548

      Test Case: testBinaryComparatorWhenSubtractionIsDivisibleByMaxIntValue

      • Fails due to changing the compare from `<` to `>` as the test condition (In little endian this is valid when the bytes are reversed, but not for big endian)

      Test Case: testBinaryComparatorWhenSubtractionCanOverflowLongValue

      • Fails due to using Long.compareUnsigned
      • Possible Fix: Use signed compare for big endian platforms.

      Attachments

        Issue Links

          is caused by

          Bug - A problem which impairs or prevents the functions of the product. SPARK-29918 RecordBinaryComparator should check endianness when compared by long

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            People

              Unassigned Unassigned
              jineshpatel Jinesh Patel
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: