Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-29635

Deduplicate test suites between Kafka micro-batch sink and Kafka continuous sink

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 3.0.0
    • Component/s: Structured Streaming
    • Labels:
      None

      Description

      There's a comment in KafkaContinuousSinkSuite which is most likely explaining TODO:

      https://github.com/apache/spark/blob/37690dea107623ebca1e47c64db59196ee388f2f/external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaContinuousSinkSuite.scala#L35-L39

      /**
       * This is a temporary port of KafkaSinkSuite, since we do not yet have a V2 memory stream.
       * Once we have one, this will be changed to a specialization of KafkaSinkSuite and we won't have
       * to duplicate all the code.
       */
      

      Given latest master branch has V2 memory stream now, it is a good time to deduplicate two suites into one, via having base class and let these suites override necessary things.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                kabhwan Jungtaek Lim
                Reporter:
                kabhwan Jungtaek Lim
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: