Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-23455

Default Params in ML should be saved separately

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.4.0
    • 2.4.0
    • ML
    • None

    Description

      We save ML's user-supplied params and default params as one entity in JSON. During loading the saved models, we set all the loaded params into created ML model instances as user-supplied params.

      It causes some problems, e.g., if we strictly disallow some params to be set at the same time, a default param can fail the param check because it is treated as user-supplied param after loading.

      The loaded default params should not be set as user-supplied params. We should save ML default params separately in JSON.

      Attachments

        Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. SPARK-23265 Update multi-column error handling logic in QuantileDiscretizer

          • Major - Major loss of function.
          • Resolved
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. SPARK-23244 Incorrect handling of default values when deserializing python wrappers of scala transformers

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. SPARK-23377 Bucketizer with multiple columns persistence bug

          • Blocker - Blocks development and/or testing work, production could not run
          • Resolved
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. SPARK-24058 Default Params in ML should be saved separately: Python API

          • Major - Major loss of function.
          • Resolved
          links to

          Pull request #20633 [Github] Pull Request #20633 (viirya)

          Activity

            People

              viirya L. C. Hsieh
              viirya L. C. Hsieh
              Joseph K. Bradley Joseph K. Bradley
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: