Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-11352

codegen.GeneratePredicate fails due to unquoted comment

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.5.1
    • 1.5.3, 1.6.0
    • SQL

    Description

      Somehow the code being generated ends up having comments with comment-terminators unquoted, eg.:

      /* ((input[35, StringType] <= text/html,application/xhtml+xml,application/xml;q=0.9,/;q=0.8) && (text/html,application/xhtml+xml,application/xml;q=0.9,/;q=0.8 <= input[36, StringType])) */

      with emphasis on ... =0.9,*/...

      This leads to a org.codehaus.commons.compiler.CompileException

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. SPARK-12451 Regexp functions don't support patterns containing '*/'

          • Major - Major loss of function.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. SPARK-15165 Codegen can break because toCommentSafeString is not actually safe

          • Blocker - Blocks development and/or testing work, production could not run
          • Resolved
          links to

          Pull request #10072 [Github] Pull Request #10072 (yhuai)

          Pull request #10084 [Github] Pull Request #10084 (yhuai)

          Activity

            People

              yhuai Yin Huai
              mrares Rares Mirica
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: