[SOLR-7277] DocBuilder should pass EntityProcessorWrapper in notifyListener - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Won't Fix
Affects Version/s: 5.0
Fix Version/s: None
Component/s: contrib - DataImportHandler
Labels:
None
Environment:

Windows 7; Apache Solr 5.0.0

Description

Within an onImportEnd listener, I would like to be able to do this:

String entityName = context.getEntityAttribute("name");

Because the DocBuilder.notifyListener passes a null EntityProcessorWrapper, the entity is not accessible at all in the onImportEnd event.

Suggested Fix: DocBuilder.notifyListener should pass the currentEntityProcessorWrapper into the ContextImpl constructor on line 173 of DocBuilder.java

 private void notifyListener(EventListener listener, Exception lastException) {
    String currentProcess;
    if (dataImporter.getStatus() == DataImporter.Status.RUNNING_DELTA_DUMP) {
      currentProcess = Context.DELTA_DUMP;
    } else {
      currentProcess = Context.FULL_DUMP;
    }
    ContextImpl ctx = new ContextImpl(null, getVariableResolver(), null, currentProcess, session, null, this); //FIX: PASS first argument
    ctx.setLastException(lastException);
    listener.onEvent(ctx);
  }