Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-16834

Remove unused AddReplicaCmd properties

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Minor
    • Resolution: Invalid
    • main (10.0)
    • None
    • SolrCloud

    Description

      AddReplicaCmd currently has logic to read and use a parameter called 'skipCreateReplicaInClusterState' (which defaults to false). Unfortunately, CollectionsHandler doesn't actually pass that parameter.

      It looks like the parameter was added for use by the autoscaling "simulation" framework (see SOLR-11285). When that was cut from Solr later on the parameter was removed from CollectionsHandler, but the corresponding change to AddReplicaCmd was never made.

      We should remove this line from AddReplicaCmd, and any other references to that now-defunct param.

      Attachments

        Activity

          People

            Unassigned Unassigned
            gerlowskija Jason Gerlowski
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: