Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-16509

All query classes should be immutable

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Patch Available
    • Critical
    • Resolution: Unresolved
    • None
    • None
    • query
    • None

    Description

      As part of investigating SOLR-16489, it was found that there are Query classes in Solr that extend https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/search/Query.java and are not immutable. One example being https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/search/WrappedQuery.java

      These classes should have final fields and no setters. They should be effectively immutable.

      Attachments

        Issue Links

          Activity

            People

              krisden Kevin Risden
              krisden Kevin Risden
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1.5h
                  1.5h