Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-16507

Remove Snitch. Simplify NodeStateProvider usage.

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 9.3
    • None

    Description

      The NodeStateProvider is a relic relating to the old autoscaling framework that was removed in Solr 9.  The only remaining usage of it is for SplitShardCmd to check the disk space.  For this, it could use the metrics api. (Update: keep NodeStateProvider albeit simplify the default impl by removing Snitch stuff. Add "NodeValueFetcher").

      I think we'll observe that Snitch and other classes in org.apache.solr.common.cloud.rule can be removed as well, as it's related to NodeStateProvider.

      Only org.apache.solr.cluster.placement.impl.AttributeFetcherImpl#getMetricSnitchTag and org.apache.solr.cluster.placement.impl.NodeMetricImpl refer to some constants in the code to be removed.  Those constants could move out, consolidated somewhere we think is appropriate.

      Attachments

        Issue Links

          Activity

            People

              noble.paul Noble Paul
              dsmiley David Smiley
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 3h 10m
                  3h 10m