[SOLR-16182] Close ZkClientClusterStateProvider in tests to avoid thread leak - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Test
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 9.1, main (10.0), 9.0.1
Component/s: Tests
Labels:
None

Description

https://lists.apache.org/list?builds@solr.apache.org:lte=1M:org.apache.solr.client.solrj.impl.CloudSolrClientBuilderTest.classMethod

I personally haven't seen this fail locally, but looking at the test, ZkClientClusterStateProvider is created but never closed.

magibney pointed out in the PR this problem most likely exists elsewhere so will fix it up all at once:

> find solr -name '*.java' | xargs grep -l 'ZkClientClusterStateProvider\.from('
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrClientMultiConstructorTest.java
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrClientBuilderTest.java
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientBuilderTest.java
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrClientTest.java
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientMultiConstructorTest.java

Attachments

Issue Links

is related to

SOLR-16185 CloudSolrClientCacheTest leaks threads

Closed

links to

GitHub Pull Request #837

Activity

People

Assignee:: Kevin Risden

Reporter:: Kevin Risden

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 05/May/22 12:51

Updated:: 10/Jan/23 20:45

Resolved:: 05/May/22 17:17

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

50m