Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-15629 Improve the way we "expect" ERROR messages in tests
  3. SOLR-15703

replace all SolrException.log usage in Solr to just call log.error(...) directly

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • main (10.0), 9.3
    • None

    Description

      There is a lot of code in Solr that uses SolrException.log(log, ..) as a way to ensure that the resulting exception can be "ignored" in tests via SolrException.ignorePatterns / SolrTestCaseJ4.ignoreException()

      This "test feature" is being cleaned up / replaced in SOLR-15697 so that any log message can be "muted" - meaning we don't need this special hook/hack – we can replace all calls to SolrException.log(log, ..) with (more efficient) direct calls to log.error(..) 

      But this change isn't trivially to do in a scripted/automated manner – notably many of these SolrException.log(log, ..) use string concatenation that needs to be replaced with logging parameterization to pass our validateLogCalls check.

      Attachments

        Issue Links

          Activity

            People

              krisden Kevin Risden
              hossman Chris M. Hostetter
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 10m
                  1h 10m