Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-15595

Partial results from shard queries needlessly discarded for queries without sort fields

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 8.1, 8.1.1, 8.2, 8.3, 8.3.1, 8.4, 8.4.1, 8.5, 8.5.1, 8.5.2, 8.6, 8.6.1, 8.6.2, 8.6.3, 8.7, 8.8, 8.8.1, 8.8.2, 8.9
    • 9.0, 8.10
    • None
    • None

    Description

      SOLR-9882 introduced a behavior change in handing partial results from a shard when a timeout occurs. If a shard returns partial results and an empty sortValues, then all the results for a shard are discarded.  For a scoring query the sortValues is empty, so partial results results are never included in the merged results. If all shards timeout, then zero results are returned.

      Co-incidentally, in some timeout scenarios sortValues is null. This was recently addressed in SOLR-14758, but that code is impacted by the proposed change, which is to set sortValues to an empty list if is null and to no longer skip merging the shard results when sortValues is empty and the shard results are partial. There may be necessary changes further down in the merge phase when sortValues are missing, partial results are returned and the sortSpec expects sortValues.

      Attachments

        Issue Links

          Activity

            People

              epugh Eric Pugh
              makosten Michael Kosten
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 3h 20m
                  3h 20m