Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-15531

IllegalArgumentException while executing streaming expression with significantTerms on an empty collection

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 8.7
    • 9.0, 8.10
    • None
    • None

    Description

      We use the significantTerms function quite a lot against aliases. Recently that ran into an error, when one of our collections in that alias didn't contain any documents.

      It's very easy to reproduce:
      1. Create an empty collection
      2. Execute the following streaming expression

      significantTerms(empty,
                       q="concepts_ss:[* TO *]",
                       field="concepts_ss",
                       limit="50",
                       minDocFreq="3",
                       maxDocFreq="0.7",
                       minTermLength="4")

      Solr Log Stacktrace:

      2021-07-12 16:01:29.622 ERROR (qtp1508181426-479) [c:empty s:shard1 r:core_node2 x:empty_shard1_replica_n1] o.a.s.h.RequestHandlerBase java.lang.IllegalArgumentException: length needs to be >= 1
      	at org.apache.lucene.util.SparseFixedBitSet.<init>(SparseFixedBitSet.java:60)
      	at org.apache.solr.search.SignificantTermsQParserPlugin$SignifcantTermsCollector.<init>(SignificantTermsQParserPlugin.java:115)
      	at org.apache.solr.search.SignificantTermsQParserPlugin$SignificantTermsQuery.getAnalyticsCollector(SignificantTermsQParserPlugin.java:92)
      	at org.apache.solr.search.AnalyticsQuery.getFilterCollector(AnalyticsQuery.java:76)
      	at org.apache.solr.search.SolrIndexSearcher.getProcessedFilter(SolrIndexSearcher.java:1079)
      	at org.apache.solr.search.SolrIndexSearcher.getDocListNC(SolrIndexSearcher.java:1532)
      	at org.apache.solr.search.SolrIndexSearcher.getDocListC(SolrIndexSearcher.java:1413)
      	at org.apache.solr.search.SolrIndexSearcher.search(SolrIndexSearcher.java:596)
      	at org.apache.solr.handler.component.QueryComponent.doProcessUngroupedSearch(QueryComponent.java:1513)
      	at org.apache.solr.handler.component.QueryComponent.process(QueryComponent.java:403)
      	at org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:360)
      	at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:214)
      	at org.apache.solr.core.SolrCore.execute(SolrCore.java:2627)
      	at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:795)
      	at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:568)
      	at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:415)
      	at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:345)
      	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1596)
      	at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:545)
      	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
      	at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:590)
      	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
      	at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
      	at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1610)
      	at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
      	at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1300)
      	at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
      	at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:485)
      	at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1580)
      	at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
      	at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1215)
      	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
      	at org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:221)
      	at org.eclipse.jetty.server.handler.InetAccessHandler.handle(InetAccessHandler.java:177)
      	at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:146)
      	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
      	at org.eclipse.jetty.rewrite.handler.RewriteHandler.handle(RewriteHandler.java:322)
      	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
      	at org.eclipse.jetty.server.Server.handle(Server.java:500)
      	at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:383)
      	at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:547)
      	at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:375)
      	at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:273)
      	at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
      	at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:103)
      	at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:117)
      	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:336)
      	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:313)
      	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:171)
      	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:129)
      	at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:375)
      	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:806)
      	at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:938)
      	at java.base/java.lang.Thread.run(Unknown Source)

      I've already prepared Unit Tests to reproduce and a fix for the issue. I'll attach a pull request soon.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mdrob Mike Drob
            badbenarnold Benedikt Arnold
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 10m
                1h 10m

                Slack

                  Issue deployment