Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-15005

RequestHandlerBase's logger name should point to the implementation class

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Won't Fix
    • None
    • None
    • logging
    • None

    Description

      RequestHandlerBase is an abstract class that defines a private static Logger with a logger name of this very class. I think it should point to the implementing class (getClass()). This would require it be non-static. It's used in just one spot, from a method that isn't static, so this will work.

      Do we go farther and declare as protected and remove static loggers in all subclasses, so long as they aren't being referenced from static methods there?

      See recent comments at the end of SOLR-8330

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              dsmiley David Smiley
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: