Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-14370

Refactor bin/solr to allow external override of Jetty modules

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • scripts and tools
    • None

    Description

      The bin/solr script currently does not allow for externally overriding the modules passed to Jetty on startup.

      This PR adds the ability to override the Jetty modules on startup by setting JETTY_MODULES as an environment variable; when passed, bin/solr will pass through (and not clobber) the string verbatim into SOLR_JETTY_CONFIG. For example, you can now run:

      JETTY_MODULES=--module=foo bin/solr start

      We've added some custom Jetty modules that can be optionally enabled; this change allows us to keep our logic (regarding which modules to use) in a separate script, rather than maintaining a forked bin/solr.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              athrog Andy Throgmorton
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m