[SOLR-14000] clean up more static field leaks in tests - ASF JIRA

Agile Board

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 8.4
Component/s: None
Labels:
None

Description

See build https://jenkins.thetaphi.de/job/Lucene-Solr-8.x-Windows/577/ for example, stuff like this:

Stack Trace:
junit.framework.AssertionFailedError: Clean up static fields (in @AfterClass?) and null them, your test still has references to classes of which the sizes cannot be measured due to security restrictions or Java 9 module encapsulation:
  - private static org.apache.solr.prometheus.scraper.SolrStandaloneScraper org.apache.solr.prometheus.scraper.SolrStandaloneScraperTest.solrScraper
  - private static org.apache.solr.client.solrj.impl.HttpSolrClient org.apache.solr.prometheus.scraper.SolrStandaloneScraperTest.solrClient

Looks like security manager issue, but its not, its just static leaks in tests. Its just that the thing they leak can't be inspected to see how "big" the leak is (apparently the objects were below some threshold before).

We should just plug the leaks, null them out in AfterClass.