Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-13857

QueryParser.jj produces code that will not compile

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Won't Fix
    • None
    • None
    • query parsers
    • None

    Description

      There are 2 problems that have crept into the parser generation system.

      1. SOLR-8764 removed deprecated methods that are part of a generated interface (and the implementation thereof). It's kind of stinky that Javacc is generating an interface that includes deprecated methods, but deleting them from the generated class means that re-generation causes compiler errors, so this should probably be reverted.
      2. SOLR-11662 changed the signature of org.apache.solr.parser.QueryParser#newFieldQuery to add a parameter, but did not update the corresponding portion of the QueryParser.jj file, and so the method signature reverts upon regeneration, causing compile errors.
      3. There are a few places where string concatenation was turned to .append()

      The pull request to be attached soon fixes these two issues such that running ant javacc-QueryParser will once again produce code that compiles.

       

      Attachments

        Issue Links

          Activity

            People

              gus Gus Heck
              gus Gus Heck
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m