Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-12801

Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

    XMLWordPrintableJSON

Details

    • Task
    • Status: Open
    • Critical
    • Resolution: Unresolved
    • None
    • None
    • None
    • None

    Description

      A single issue to counteract the single issue adding tons of annotations, the continued addition of new flakey tests, and the continued addition of flakiness to existing tests.

      Lots more to come.

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. SOLR-13310 facet.threads is using the updateExecutor

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-13300 Reproducing seed in master for DistributedFacetExistsSmallTest

          • Major - Major loss of function.
          • Closed
          contains

          Improvement - An improvement or enhancement to an existing feature or task. LUCENE-8541 Fix ant beast to not overwrite junit xml results for each beast.iters iteration.

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Test - A new unit, integration or system test. LUCENE-8545 Precommit could check for any tests in the latest commit and do a cursory beasting.

          • Major - Major loss of function.
          • Open

          Test - A new unit, integration or system test. LUCENE-8547 Add a build target that beasts all of the tests modified in the last commit.

          • Major - Major loss of function.
          • Open

          Test - A new unit, integration or system test. LUCENE-8546 Fix ant beast to fail and succeed based on whether beasting actually fails or succeeds.

          • Major - Major loss of function.
          • Closed
          incorporates

          Bug - A problem which impairs or prevents the functions of the product. SOLR-13796 Fix Solr Test Performance

          • Major - Major loss of function.
          • Resolved
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-13051 Improve TimeRoutedAlias preemptive create to play nice with tests

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Task - A task that needs to be done. SOLR-13867 Make Solrcloud stable and performant and capable of having passing tests.

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. SOLR-13021 You cannot safely create and delete the same collection.

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. SOLR-12933 Fix SolrCloud distributed commit.

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. SOLR-13036 JettySolrRunner's port retry is broken

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-11872 Refactor test infra to work with a managed SolrClient; ditch TestHarness

          • Major - Major loss of function.
          • Open

          Test - A new unit, integration or system test. SOLR-12313 Removing TestInjection#waitForInSyncWithLeader

          • Major - Major loss of function.
          • Resolved

          Wish - General wishlist item. SOLR-10229 See what it would take to shift many of our one-off schemas used for testing to managed schema and construct them as part of the tests

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open
          links to

          Web Link GitHub Pull Request #486

          1.
          		 Remove static modifier from Overseer queue access. Sub-task Resolved Mark Miller
          2.
          		 Introduce more checks for shutdown and closed to improve clean close and shutdown. Sub-task Resolved Mark Miller
          3.
          		 Introduce AlreadyClosedException to clean up silly close / shutdown logging. Sub-task Resolved Mark Miller
          4.
          		 Replace cluster state polling with ZkStateReader#waitFor. Sub-task Resolved Mark Miller
          5.
          		 Fix all tests in org.apache.solr.search and begin a defense of them. Sub-task Open Mark Miller
          6.
          		 Fix all tests in org.apache.solr.update and begin a defense of them. Sub-task Open Mark Miller
          7.
          		 Fix all Solr tests to work with ant beast. Sub-task Resolved Mark Miller
          8.
          		 Introduce a new set of Mock objects that cover key parts of the system and are easy to use. Sub-task Open Mark Miller
          9.
          		 Resurrect regular test beasting reports. Sub-task Open Mark Miller
          10.
          		 Separate Solr unit tests and integration tests. Sub-task Open Unassigned
          11.
          		 ant test (without badapples=false) should pass easily for developers. Sub-task Open Mark Miller
          12.
          		 Harden LeaderTragicEventTest. Sub-task Open Mark Miller
          13.
          		 The new AutoScaling tests are way to flaky and need special attention. Sub-task Resolved Unassigned
          14.
          		 Harden AutoAddReplicasPlanActionTest#testSimple Sub-task Resolved Unassigned
          15.
          		 Harden ChaosMonkeySafeLeaderWithPullReplicasTest Sub-task Open Unassigned
          16.
          		 Harden MaxSizeAutoCommitTest Sub-task Closed Chris M. Hostetter
          17.
          		 Harden HttpSolrCallGetCoreTest Sub-task Open Mark Miller
          18.
          		 Harden TestSimGenericDistributedQueue. Sub-task Closed Jason Gerlowski
          19.
          		 Harden TestSQLHandler. Sub-task Closed Joel Bernstein
          20.
          		 clean up suspicious ExecutorService lifecycles in MiniSolrCloudCluster Sub-task Closed Chris M. Hostetter
          21.
          		 Harden BasicAuthIntegrationTest. Sub-task Resolved Mark Miller
          22.
          		 many cloud/autoscaling tests are using System.currentTimeMillis() for timing comparisons (under the covers) Sub-task Closed Chris M. Hostetter
          23.
          		 Harden SaslZkACLProviderTest. Sub-task Open Unassigned
          24.
          		 refactor and harden common 'suspend-trigger' patern in autoscaling test setup Sub-task Closed Chris M. Hostetter
          25.
          		 Redesign integration tests for nodeAdded/nodeLost trigger state restoration Sub-task Closed Chris M. Hostetter
          26.
          		 Harden SearchRateTriggerIntegrationTest Sub-task Closed Chris M. Hostetter
          27.
          		 Testing of TLOG Replicas needs to be re-instated, may be hiding bugs Sub-task Open Unassigned
          28.
          		 Need reliable example (Test) of how to use TestInjection.failReplicaRequests Sub-task Open Unassigned
          29.
          		 TriLevelCompositeIdRoutingTest makes no sense -- can never fail Sub-task Closed Chris M. Hostetter
          30.
          		 when TestInjection.nonGracefullClose causes a TestShutdownFailError, test is garunteed tofail due to leaked objects (causes failures in (Hdfs)RestartWhileUpdatingTest) Sub-task Open Unassigned
          31.
          		 numerous problems with LIROnShardRestartTest Sub-task Resolved Unassigned
          32.
          		 restore ability for BaseDistributedSearchTestCase subclasses to use null keys in "handle" when comparing responses Sub-task Open Mark Miller

          Activity

            People

              markrmiller@gmail.com Mark Miller
              markrmiller@gmail.com Mark Miller
              Votes:
              4 Vote for this issue
              Watchers:
              18 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h
                  1h