Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-12301

Umbrella issue: paramaterize logging calls in Solr, use consistent naming conventions for the logger

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 8.6
    • None
    • None

    Description

      See the discussion at SOLR-12286 for a lot of background, but the short form is that logging calls of the form

      log.info("somehting" + "something");
      and
      log.info("soemthing {}", object.someFunction());

      where someFunction includes toString()

      generate useless garbage/work even when the message is not printed.

      log.info("somehting {}", "something");
      and
      log.info("soemthing {}", object);

      do not. The first form is something of a relic, and there are even some uses of the second.

      This will entail a LOT of changes, but almost all secretarial. I'll take it in chunks.

      Attachments

        Issue Links

          Activity

            People

              erickerickson Erick Erickson
              erickerickson Erick Erickson
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: