Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10807

Randomize PointFields in all tests unless explicit reason not to

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • None
    • 7.0, 7.1, 8.0
    • None
    • None

    Description

      We need to seriously beef up our testing of PointFields to figure out what Solr features don't currently work with PointFields.

      The existing Trie/Point randomization logic in SolrTestCaseJ4 is a good start – but only a handful of schema files leverage it.


      Allthough a jira/SOLR-10807 branch was originally created with this goal, it was ultimately just used for initial experimentation, and has been abandoned. The "meat" of the work needed to improve how we randomize in Point fields was done in SOLR-10864, and other sub-tasks of this issue have been / are being used to track rolling out this randomization to more and more test schema files and validating the affected tests.

      This effort is now highly parallelizable – so here are some rough guidelines/suggestions for folks interested in contributing to this effort:

      Attachments

        1. core.test.log.fde06f34b7f9d0916a134b3efaa8780892ff8e39.txt
          24.75 MB
          Chris M. Hostetter
        2. core.test.log.txt
          9.46 MB
          Chris M. Hostetter

        Issue Links

          1.
          Add static (test only) boolean to PointField indicating 'precisionStep' should be ignored so we can simplify points randomization in our schemas Sub-task Resolved Chris M. Hostetter
          2.
          SuppressPointFields should require a bugUrl Sub-task Resolved Chris M. Hostetter
          3.
          Randomize PointFields in all solrj tests unless explicit reason not to Sub-task Resolved Chris M. Hostetter
          4.
          Randomize PointFields in all contrib tests unless explicit reason not to Sub-task Resolved Chris M. Hostetter
          5.
          Randomize PointFields in all tests using schema-*sort* files Sub-task Resolved Chris M. Hostetter
          6.
          Randomize PointFields in CdcrBootstrapTest Sub-task Resolved Chris M. Hostetter
          7.
          Randomize the usage of Points based numerics in schema15.xml and all impacted tests Sub-task Resolved Chris M. Hostetter
          8.
          Randomize PointFields in schema-docValues\*.xml and all affected tests Sub-task Resolved Chris M. Hostetter
          9.
          Randomize PointFields and general cleanup in schema files that have completley unused Trie fieldTYpes Sub-task Resolved Chris M. Hostetter
          10.
          Randomize PointFields in schema-add-schema-fields-update-processor.xml in core/src/test-files/solr/collection1 Sub-task Closed Anshum Gupta
          11.
          Randomize PointFields in schema-blockjoinfacetcomponent.xml and all related tests Sub-task Closed Anshum Gupta
          12.
          Randomize PointFields in schema-custom-field.xml and all related tests Sub-task Closed Anshum Gupta
          13.
          Randomize PointFields in cloud-dynamic configset and all related tests Sub-task Closed Anshum Gupta
          14.
          Randomize PointFields in doc-expiry & exitable-directory test configsets and all affected tests Sub-task Closed Chris M. Hostetter
          15.
          Randomize PointFields in _default test configset and all affected tests Sub-task Resolved Steven Rowe
          16.
          Randomize PointFields in schema-id-and-version-fields-only.xml and all affected tests Sub-task Closed Chris M. Hostetter
          17.
          Randomize PointFields in cloud-managed-preanalyzed &schema-preanalyzed.xml and all affected tests Sub-task Closed Chris M. Hostetter
          18.
          Randomize PointFields in "cloud-dynamic" test configset and all affected tests Sub-task Resolved Steven Rowe
          19.
          Randomize PointFields in "cloud-minimal" test configset and all affected tests Sub-task Closed Steven Rowe
          20.
          Randomize PointFields in schema-rest.xml and all affected tests Sub-task Closed Chris M. Hostetter
          21.
          Randomize PointFields in "cloud-hdfs" test configset and all affected tests Sub-task Closed Steven Rowe
          22.
          Randomize PointFields in "cloud-minimal-jmx" and "cloud-minimal-inplace-updates" test configsets Sub-task Closed Steven Rowe
          23.
          Randomize PointFields in "cloud-subdirs" and "configset-2" test configsets Sub-task Closed Steven Rowe
          24.
          Randomize PointFields in "cloud-managed" and "cloud-managed-upgrade" test configsets Sub-task Closed Steven Rowe
          25.
          Randomize PointFields in collection1/conf/: schemasurround.xml, schema-sql.xml, and schema-spatial.xml Sub-task Closed Steven Rowe
          26.
          Randomize PointFields in schema-folding.xml and all affected tests Sub-task Closed Chris M. Hostetter
          27.
          Randomize PointFields in analysis-err-schema.xml, schema-hash.xml, and all affected tests Sub-task Closed Chris M. Hostetter
          28.
          Randomize PointFields in schema-customfield.xml and TestOverriddenPrefixQueryForCustomFieldType Sub-task Closed Chris M. Hostetter
          29.
          Randomize PointFields in schema-psuedo-fields.xml, schema-multiword-synonyms.xml, and all affected tests Sub-task Closed Steven Rowe
          30.
          Randomize PointFields in schema-numeric.xml and all related tests Sub-task Closed Steven Rowe
          31.
          Randomize PointFields in schema-behavior.xml, schema-enums.xml, and all affected tests Sub-task Closed Steven Rowe
          32.
          Randomize PointFields in schema-HighlighterMaxOffsetTest.xml, schema-luceneMatchVersion.xml, schema-minimal-atomic-stress.xml, and all affected tests Sub-task Closed Steven Rowe
          33.
          Remove trie fieldTypes from schema-points.xml Sub-task Closed Chris M. Hostetter
          34.
          Randomize PointFields in schema-trie.xml and TestTrie Sub-task Closed Chris M. Hostetter
          35.
          Randomize PointFields in test classes that currently have usage of Trie field classes/names hardcoded Sub-task Closed Chris M. Hostetter

          Activity

            People

              hossman Chris M. Hostetter
              hossman Chris M. Hostetter
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: