Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10734

Multithreaded test/support for AtomicURP broken

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 7.4, 8.0
    • None
    • None

    Description

      The multithreaded test doesn't actually start the threads, but only invokes the run directly. The join afterwards doesn't do anything, hence.

      diff --git a/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java b/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
      index f3f833d..10b7770 100644
      --- a/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
      +++ b/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
      @@ -238,7 +238,7 @@ public class AtomicUpdateProcessorFactoryTest extends SolrTestCaseJ4 {
                 }
               }
             };
      -      t.run();
      +      t.run(); // red flag, shouldn't this be t.start?
             threads.add(t);
             finalCount += index; //int_i
           }
      

      Attachments

        1. log-snippet
          119 kB
          Amrit Sarkar
        2. Screen Shot 2017-05-31 at 4.50.23 PM.png
          729 kB
          Amrit Sarkar
        3. SOLR-10734.patch
          3 kB
          Amrit Sarkar
        4. SOLR-10734.patch
          1 kB
          Amrit Sarkar
        5. testMaster_2500
          94 kB
          Amrit Sarkar
        6. testResults7_10
          47 kB
          Amrit Sarkar
        7. testResultsMaster_10
          52 kB
          Amrit Sarkar
        8. SOLR-10734.patch
          1 kB
          Amrit Sarkar
        9. SOLR-10734.patch
          2 kB
          Shalin Shekhar Mangar
        10. SOLR-10734-fix2.patch
          4 kB
          Shalin Shekhar Mangar
        11. SOLR-10734-fix2.patch
          3 kB
          Shalin Shekhar Mangar

        Issue Links

          Activity

            People

              shalin Shalin Shekhar Mangar
              ichattopadhyaya Ishan Chattopadhyaya
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: