Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-11582

VaultDistrubtionPackageBuilderFactory mixed up ordering of attribute definition for type

Agile BoardAttach filesAttach ScreenshotAdd voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • Content Distribution Journal Core 0.1.26
    • None
    • Content Distribution
    • None

    Description

      The VaultDistributionPackageBuilderFactory's AttributeDefintion [0] for "type" has the label and values swapped. 

      The impact is that someone creating an OSGi configuration that uses the value of "in memory packages" will not have in memory packages created as the "label" is what is used to check if packages should be created in memory [1].

      The OSGi docs for Option [2] identify the label as being a human readable string and the value should be the value.

      At the same time fix the typo in the ObjectClassDefintion [3]

       

      [0] https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/serialization/impl/vlt/VaultDistributionPackageBuilderFactory.java#L76-L80

       [1]https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/serialization/impl/vlt/VaultDistributionPackageBuilderFactory.java#L241

       [2] http://docs.osgi.org/javadoc/r6/cmpn/org/osgi/service/metatype/annotations/Option.html 

       [3] https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/serialization/impl/vlt/VaultDistributionPackageBuilderFactory.java#L71 

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            bhellema Ben Helleman

            Dates

              Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0h
              0h
              Logged:
              Time Spent - 20m
              20m

              Slack

                Issue deployment