Uploaded image for project: 'Qpid'
  1. Qpid
  2. QPID-5486

Creating paged queue can overwrite existing qpidd files

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      Description of problem:
      When creating paged queue, there is no check whether the file /var/lib/qpidd/<queue_name> exists or not. Hence it is possible to rewrite files like "lock" or "systemId" there.

      (Severity of the bug depends on importance of these files for the broker, that apparently is fine to be started with the files overwritten)

      Note that creating a file named e.g. "rhm" (that is directory in /var/lib/qpidd) is disallowed even now.

      Version-Release number of selected component (if applicable):
      0.27 (current upstream)

      How reproducible:
      100%

      Steps to Reproduce:
      qpid-send -a "lock; {create:always, delete:always, node: { x-declare: {arguments: {'qpid.paging':'True' }}}}"
      echo $?
      qpid-send -a "systemId; {create:always, delete:always, node: { x-declare: {arguments: {'qpid.paging':'True' }}}}"
      echo $?

      Actual results:
      0
      0

      Expected results:
      Both should return an error like:
      qpid-send: framing-error: Attempting to re-write file /home/pmoravec/.qpidd/systemId for paged queue "systemId" (/home/pmoravec/qpid-trunk/qpid/cpp/src/qpid/sys/posix/MemoryMappedFile.cpp:68)

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            pmoravec Pavel Moravec
            pmoravec Pavel Moravec
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified

                Slack

                  Issue deployment