Uploaded image for project: 'Qpid Proton'
  1. Qpid Proton
  2. PROTON-968

[proton-j] validate local/remote channel-max is adhered to

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • proton-0.12.0
    • proton-j-future
    • proton-j
    • None

    Description

      The channel-max handling in proton-j is broken.

      Transport[Impl] defines get/setChannelMax methods, which allow controlling the value sent in the Open frame emmitted for the connection. It defaults to the maximum 65535.

      The ConnectionImpl object has a getMaxChannels method that returns a hard coded value of 65535, and it is this limit value that is used by TransportImpl when selecting local channel numbers for sending Begin frame for new sessions. As such, it pays no notice of the limit value it announced in its Open frame, which may have been lower if configured on the transport.

      The remote channel-max receiver from the peer isn't used at all other than for return via getRemoteChannelMax(). The above process will similarly pay it no attention to it when selecting channel numbers for new sessions and so may select a channel number above the remote peers limit [and perhaps also its own, again].

      Attachments

        Issue Links

          is blocked by

          Improvement - An improvement or enhancement to an existing feature or task. PROTON-281 Engine should handle errors by generating implicit CLOSE frame

          • Major - Major loss of function.
          • Open
          is related to

          Bug - A problem which impairs or prevents the functions of the product. PROTON-493 channel max is not exposed

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. PROTON-918 Jython interop tests failing since e38957ae5115

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. PROTON-842 proton-c should honor channel_max

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. PROTON-713 TransportImpl#setChannelMax does not enforce legal value range, may cause unexpected results

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              Unassigned Unassigned
              robbie Robbie Gemmell
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: